Remove duplicate delgators for all services #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergeDelegators' documentation says that it merges delegators avoiding multiple same delegators for the same service. However, from experimenting with it, duplicates were allowed, as best as I could tell. So, I've created this small patch to ensure that duplicates are removed, along with a covering test for it to verify the change. Signed-off-by: Matthew Setter <[email protected]>
Signed-off-by: Matthew Setter <[email protected]>
settermjd
force-pushed
the
fix-bug-in-delegator-list-creation
branch
from
5855a09 to
d734c7d
Compare
alexmerlin
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Checked the content of $this->delegators, before the fix:
array(1) {
["DateTime"]=>
array(2) {
[0]=>
string(54) "Laminas\ContainerConfigTest\TestAsset\DelegatorFactory"
[1]=>
string(54) "Laminas\ContainerConfigTest\TestAsset\DelegatorFactory"
}
}
and after the fix:
array(1) {
["DateTime"]=>
array(1) {
[0]=>
string(54) "Laminas\ContainerConfigTest\TestAsset\DelegatorFactory"
}
}
This fixes the duplicate delegator issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ServiceManager::mergeDelegators()documentation says that it merges delegators avoiding multiple same delegators for the same service. However, from experimenting with it, duplicates are allowed. So, I've created this small patch to ensure that duplicates are removed, along with a covering test for it to verify the change.